fix(skeleton): read/expose the correct custom attribute associated with each vertex #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th each vertex Previously, the shader read the attribute for the opposing vertex of each line segment.
briossant
pushed a commit
to briossant/neuroglancer
that referenced
this pull request
Nov 10, 2025
…th each vertex (google#822) Previously, the shader read the attribute for the opposing vertex of each line segment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the shader read the attribute for the opposing vertex of each line segment.
I noticed with #820 that the lines were getting drawn with inverse of the expected width change. It seems pretty clear to me now that this is the correct calculation.
getLineEndpointIndex returns 0 for vertexA (aVertexIndex.x) and 1 for vertexB (aVertexIndex.y) so to use vertexA we need 1 - getLineEndpointIndex and getLineEndpointIndex for vertexB.