-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify what happened to Spanish subdivisions #160
Comments
Is this still an issue. AFAICT the iso-ids are present, and the 'key' values are the full names not abbreviations. |
I don't see any changes compared to when I opened the issue. E.g. https://chromium-i18n.appspot.com/ssl-address/data/ES/L has no isoid. |
I am confused on the province treatment as well. For reference, here is the current data for ES, after pretty printing the JSON:
https://www.gstatic.com/chrome/autofill/libaddressinput/chromium-i18n/ssl-address/data/ES The public guidance I have found is that the province is optional, but is spelled out when supplied.
https://www.angloinfo.com/how-to/spain/housing/postal-system Shouldn't the
https://github.com/google/libaddressinput/wiki/AddressValidationMetadata Here are some examples from other countries:
|
In the past 4 months there has been a shift in how Spanish subdivisions are handled.
The ISO list is mixed language-wise, provinces are named in their majority language, hence Lleida instead of Llerida, etc. This was the approach taken by the dataset as well. In 2018 the ES list changed:
So, I'm asking for clarification, and treating #3 as a bug.
I've had to revert to the 2017 version of the list in commerceguys/addressing, cause even the translation change was confusing users, who were used to the mixed list.
The text was updated successfully, but these errors were encountered: