Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy CI failed on loongarch qemu test #2410

Open
jinboson opened this issue Dec 13, 2024 · 3 comments
Open

numpy CI failed on loongarch qemu test #2410

jinboson opened this issue Dec 13, 2024 · 3 comments

Comments

@jinboson
Copy link

jinboson commented Dec 13, 2024

Hi, @jan-wassenberg .
Numpy CI failed on loongarch qemu test, here is the PR link : numpy/numpy#27856.
The error link is : https://github.com/numpy/numpy/actions/runs/12312221518/job/34363842899?pr=27856.
I haven't figured out the problem. Is that because we haven't added instrinsics support into highway after we added LSX/LASX targets?

@jan-wassenberg
Copy link
Member

Yes, those errors are because generic_ops-inl.h expects the intrinsics file to define many things such as VFromD, but because it's an empty header, that does not happen.
We cannot actually compile the HWY_LSX target until it is actually implemented. However, you could define HWY_COMPILE_ONLY_SCALAR and then it should at least build, though it would only use scalar (non-SIMD) code.

@jinboson
Copy link
Author

jinboson commented Dec 16, 2024

Sorry for the delay reply. @jan-wassenberg Thank you so much, that works. Sorry, it will take some time to add intrinsics into highway for LSX/LASX targets, so we think we can make a minor change on Numpy CI test for loongarch to ensure the build completes successfully. The change is that adding CXXFALGS="-DHWY_COMPILE_ONLY_SCALAR" in the front of the build cmd, like below:

CXXFALGS="-DHWY_COMPILE_ONLY_SCALAR" spin build [OPTINS] [MESON_ARGS] ...

In this way the numpy would build. The CXXFALGS can be removed as long as the actual intrinsics for LSX/LASX targets are added. If there is any better idea or different opinions please feel free to let me know. Thanks. :D

@jan-wassenberg
Copy link
Member

Sure, no worries.
I'm adding it to Highway for starters and we might also want to add this to numpy - @Mousius , what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants