Skip to content

udp: release the cloned PacketBuffer in Forwarder.HandlePacket #13242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibondarenko1 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

udp: release the cloned PacketBuffer in Forwarder.HandlePacket #13242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/tcpip/transport/udp/forwarder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,15 @@ func NewForwarder(s *stack.Stack, handler ForwarderHandler) *Forwarder {
// This function is expected to be passed as an argument to the
// stack.SetTransportProtocolHandler function.
func (f *Forwarder) HandlePacket(id stack.TransportEndpointID, pkt *stack.PacketBuffer) bool {
return f.handler(&ForwarderRequest{
r := &ForwarderRequest{
stack: f.stack,
id: id,
pkt: pkt.Clone(),
})
}
// The forwarder handler is synchronous, so the cloned packet only needs
// to outlive the handler call. Release it on every return path.
defer r.pkt.DecRef()
return f.handler(r)
}

// ForwarderRequest represents a session request received by the forwarder and
Expand Down