Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BackPress to OnBackPressedCallback #2945

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

anandwana001
Copy link
Collaborator

@anandwana001 anandwana001 commented Dec 17, 2024

Fixes #2944

super.onBackPressed() is now deprecated, and documentation suggested using OnBackPressedCallback

Back Press should work correctly.

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign bot requested a review from gino-m December 17, 2024 14:38
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (b660181) to head (72e026e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/com/google/android/ground/MainActivity.kt 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2945      +/-   ##
============================================
- Coverage     62.54%   62.54%   -0.01%     
  Complexity     1203     1203              
============================================
  Files           267      267              
  Lines          6357     6362       +5     
  Branches        879      880       +1     
============================================
+ Hits           3976     3979       +3     
- Misses         1831     1833       +2     
  Partials        550      550              
Files with missing lines Coverage Δ
...ain/java/com/google/android/ground/MainActivity.kt 48.38% <42.85%> (+0.65%) ⬆️

@shobhitagarwal1612
Copy link
Member

Can you please update description & specify how the change was verified?

@shobhitagarwal1612 shobhitagarwal1612 merged commit 1ca9a52 into master Dec 19, 2024
4 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the anandwana001/2944/back-press-deprecate-fix branch December 19, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Deprecated super.onBackPressed()
2 participants