Remove requireNotNull from argument check #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2940 +/- ##
============================================
+ Coverage 62.52% 62.54% +0.01%
Complexity 1203 1203
============================================
Files 267 267
Lines 6357 6357
Branches 880 879 -1
============================================
+ Hits 3975 3976 +1
Misses 1831 1831
+ Partials 551 550 -1
|
.../src/main/java/com/google/android/ground/ui/offlineareas/viewer/OfflineAreaViewerFragment.kt
Outdated
Show resolved
Hide resolved
…rgument-handle' into anandwana001/2649/offline-area-argument-handle
shobhitagarwal1612
approved these changes
Dec 17, 2024
shobhitagarwal1612
deleted the
anandwana001/2649/offline-area-argument-handle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2649
Why navigateUp?
In this OfflineAreaViewerViewModel also, we are navigating up incase of null data, as per earlier discussion.
@shobhitagarwal1612 PTAL?