Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize SurveyConverter.toSurvey() #2939

Merged

Conversation

anandwana001
Copy link
Collaborator

@auto-assign auto-assign bot requested a review from sufyanAbbasi December 17, 2024 10:49
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.57%. Comparing base (1ca9a52) to head (013c2d3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...sistence/remote/firebase/schema/SurveyConverter.kt 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2939      +/-   ##
============================================
+ Coverage     62.54%   62.57%   +0.02%     
- Complexity     1203     1207       +4     
============================================
  Files           267      267              
  Lines          6362     6367       +5     
  Branches        880      879       -1     
============================================
+ Hits           3979     3984       +5     
  Misses         1833     1833              
  Partials        550      550              
Files with missing lines Coverage Δ
...sistence/remote/firebase/schema/SurveyConverter.kt 75.00% <81.25%> (+8.33%) ⬆️

@shobhitagarwal1612 shobhitagarwal1612 merged commit 543795e into master Dec 19, 2024
4 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the anandwana001/2857/survey-converter-code-clean branch December 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code health] Clean up SurveyConverter.toSurvey()
2 participants