Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code health] Stop exposing Activity to managers #2912

Open
gino-m opened this issue Dec 10, 2024 · 3 comments
Open

[Code health] Stop exposing Activity to managers #2912

gino-m opened this issue Dec 10, 2024 · 3 comments
Labels
type: code health Improvements to readability or robustness of codebase

Comments

@gino-m
Copy link
Collaborator

gino-m commented Dec 10, 2024

No description provided.

@gino-m gino-m added the type: code health Improvements to readability or robustness of codebase label Dec 10, 2024
@anandwana001
Copy link
Collaborator

Any example @gino-m

@shobhitagarwal1612
Copy link
Member

ActivityStreams.kt?

@gino-m
Copy link
Collaborator Author

gino-m commented Dec 18, 2024

I think we should evaluate all uses of withActivity and come up with a simpler approach. Passing the Activity through a Flow is likely to lead to memory leaks and race conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: code health Improvements to readability or robustness of codebase
Projects
Ground
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gino-m @shobhitagarwal1612 @anandwana001