Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code health] Replace StateFlow<UiState> with Flow<NavEvent> where appropriate #2897

Open
gino-m opened this issue Dec 4, 2024 · 0 comments
Open

[Code health] Replace StateFlow<UiState> with Flow<NavEvent> where appropriate #2897

gino-m opened this issue Dec 4, 2024 · 0 comments
Labels
type: code health Improvements to readability or robustness of codebase

Comments

@gino-m
Copy link
Collaborator

gino-m commented Dec 4, 2024

There are cases where we may accidentally be replaying navigation events after config change because we've incorrectly modeled them as LiveData or StateFlows. We should correct those cases ASAP.
@gino-m gino-m added the type: code health Improvements to readability or robustness of codebase label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: code health Improvements to readability or robustness of codebase
Projects
Ground
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gino-m