If no surveys to fill out, back arrow in survey list is a no-op

[jcqli]

After logging in to the app, if there are no surveys for you to collect data for then the back arrow does not do anything

[anandwana001]

@jcqli A Bit more detail

1. For the very first time, the back arrow clicked, it recreates the fragment
2. arrow click doesn't work

What should be the expected behavior?

Screen.Recording.2024-08-28.at.12.42.21.PM.mov

[shobhitagarwal1612]

What should be the expected behavior?

It should exit the app

[jcqli]

Hm exiting the app seems like an antipattern, are there other apps that do this? The current behavior for when there are surveys in the list is to sign to user out so maybe we should match that
@gino-m wdyt?

[gino-m]

+1 @jcqli. The current design is obsolete, perhaps at this point it's just better to update the UI as per the new designs?

@rawbzz Can you paste in the latest here?

[gino-m]

New design includes the hamburger icon. Users can sign out from there if they have no surveys.

@kenstershiro @rawbzz FYI

[anandwana001]

New design includes the hamburger icon. Users can sign out from there if they have no surveys.

@gino-m So, user can able to open the drawer and able to explore the whole app, right? Or do we need to show only signout in the drawer?

[gino-m]

New design includes the hamburger icon. Users can sign out from there if they have no surveys.

@gino-m So, user can able to open the drawer and able to explore the whole app, right? Or do we need to show only signout in the drawer?

Yes, except the "Data sync status" option will be disabled:

[anandwana001]

@shobhitagarwal1612
for this issue, we need to move our drawer layout from fragment to activity, as it is a good practice to let every fragment access the drawer.

Could you please confirm this approach, as this is bit sounds like a migration?
All the drawer responsibilities should be handled by main activity and its ViewModel and HomeScreenFragment and it's Viewmodel will only see the maps and all

[shobhitagarwal1612]

Let's prototype it once to understand the potential challenges we might face while doing this migration.

[anandwana001]

As per the last discussion with @shobhitagarwal1612 the plan from here is to sub-divide this issue:

1. Jetpack Compose Migration [Code health] Jetpack Compose Migration #2803
2. Once the Migration completes, Introduce Navigation Drawer in the MainActivity and remove from HomeFragment

[gino-m]

@anandwana001 We spoke. The Jetpack migration sounds like it might take some time. In the meantime, can we just hide the button when there's nothing in the back stack; ie when clicking would be a no-op.