Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable codecov reports and PR comments #2593

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Jul 30, 2024

Fixes #2592

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.10%. Comparing base (1da350c) to head (98f07ed).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2593      +/-   ##
============================================
+ Coverage     54.67%   55.10%   +0.43%     
+ Complexity     1366     1312      -54     
============================================
  Files           332      317      -15     
  Lines          7274     7130     -144     
  Branches        901      886      -15     
============================================
- Hits           3977     3929      -48     
+ Misses         2848     2742     -106     
- Partials        449      459      +10     
Flag Coverage Δ
service 55.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@gino-m
Copy link
Collaborator Author

gino-m commented Jul 30, 2024

Looks like something is working now:
image

@gino-m gino-m marked this pull request as ready for review July 30, 2024 21:00
@gino-m gino-m requested a review from sufyanAbbasi July 30, 2024 21:00
@gino-m gino-m changed the title [WIP] Fix codecov reports and PR comments Reenable codecov reports and PR comments Jul 30, 2024
@sufyanAbbasi
Copy link
Contributor

YAYAYAYAY! Thank you!

@gino-m gino-m merged commit e06404f into master Jul 30, 2024
4 checks passed
@gino-m gino-m deleted the gino-m/patch/fix-codecov branch July 30, 2024 21:04
scolsen pushed a commit to scolsen/ground-android that referenced this pull request Aug 1, 2024
* Rename unit test target

* Always generate code coverage report

* Run tests against devDebug

* Update path of report

* Upgrade versioner version

* Upgrade versioner plugin

* Fix gitversioner path
scolsen added a commit that referenced this pull request Aug 1, 2024
* UI: Constrain task layouts to avoid overlap.

Fixes #2516 by constraining our task container to the position of the action button dock. This ensures long multiple choice tasks aren't covered by the action buttons—the scroll region is limited to viewable area above the action button drawer.

* UI: Fix date/time task tests

The previous change (setting the task container layout to 0dp) causes espresso actions to fail in our tests on these views. Normally, android computes the height correctly given view constraints, but this doesn't appear to take place in our tests. For now, fix this by forcing the view to have a height of 1, so that the action may be performed.

* addedd test cases (#2591)

* Create codecov.yml

* Update codecov.yml

* Upgrade versioner plugin (#2595)

* Upgrade versioner plugin

* Fix gitversioner path

* Reenable codecov reports and PR comments (#2593)

* Rename unit test target

* Always generate code coverage report

* Run tests against devDebug

* Update path of report

* Upgrade versioner version

* Upgrade versioner plugin

* Fix gitversioner path

* Add unit tests for AboutFragment (#2587)

---------

Co-authored-by: Akshay Nandwana <[email protected]>
Co-authored-by: Gino Miceli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code health] Reenable codecov PR comments
2 participants