Added unit test for SyncStatusFragment #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
shobhitagarwal1612
requested changes
Aug 7, 2024
Comment on lines
72
to
74
| ?: run { | ||
| return | ||
| } |
Comment on lines
52
to
54
| /** | ||
| * Confirming the Toolbar visibility. | ||
| */ |
There was a problem hiding this comment.
The test name is pretty obvious. We don't need extra comments here.
There was a problem hiding this comment.
for all or just this one?
| * Confirming the Toolbar visibility. | ||
| */ | ||
| @Test | ||
| fun `MaterialToolbar should be Displayed`() { |
There was a problem hiding this comment.
Can we change it to Toolbar should be displayed?
| * Confirming the SyncItem List visibility. | ||
| */ | ||
| @Test | ||
| fun `SyncItem List should Displayed`() = runWithTestDispatcher { |
There was a problem hiding this comment.
change to "Sync items should be displayed"
| * Without Data, the list will not be visible on the screen. | ||
| */ | ||
| @Test | ||
| fun `SyncItem List should Not Displayed`() { |
There was a problem hiding this comment.
Same as previous comment.
| surveyRepository.selectedSurveyId = SURVEY.id | ||
| advanceUntilIdle() | ||
|
|
||
| composeTestRule.onNodeWithTag("sync list").assertIsDisplayed() |
There was a problem hiding this comment.
Can we also verify the total count of items shown?
There was a problem hiding this comment.
Yes, this needs to be done in next part of this pr, as this required a bit of extra work
shobhitagarwal1612
approved these changes
Aug 7, 2024
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2571
Part 1 PR for this screen
@shobhitagarwal1612 PTAL?