Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit test for MultipleChoiceItem #2531

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Added unit test for MultipleChoiceItem #2531

merged 9 commits into from
Jul 19, 2024

Conversation

anandwana001
Copy link
Collaborator

@anandwana001 anandwana001 commented Jul 1, 2024 •
edited
Loading

@sufyanAbbasi sufyanAbbasi self-requested a review July 1, 2024 19:26
sufyanAbbasi
sufyanAbbasi requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@sufyanAbbasi sufyanAbbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Just a few quick changes.

...a/com/google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceItemTest.kt Outdated Show resolved Hide resolved
sufyanAbbasi
sufyanAbbasi approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@sufyanAbbasi sufyanAbbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you!

@shobhitagarwal1612
Copy link
Member

/gcbrun

@shobhitagarwal1612
Copy link
Member 

* What went wrong:
Execution failed for task ':workspace:ground:ktfmtCheckTest'.
> [ktfmt] Found 1 files that are not properly formatted:
  src/test/java/com/google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceItemTest.kt

@shobhitagarwal1612
Copy link
Member

/gcbrun

@sufyanAbbasi
Copy link
Contributor

sufyanAbbasi commented Jul 15, 2024 •
edited
Loading

Sorry for missing this earlier, looks like there's a formatting error we can quickly resolve by running ktfmtFormat:

[ktfmt] Found 1 files that are not properly formatted:
src/test/java/com/google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceItemTest.kt

I can do that right now
Oops, just realized that this is in a forked repo. Once you run the formatter, it should be ready to merge.

@sufyanAbbasi
Copy link
Contributor

/gcbrun

@anandwana001
Copy link
Collaborator Author

/gcbrun

@anandwana001 anandwana001 reopened this Jul 19, 2024
@anandwana001
Copy link
Collaborator Author

/gcbrun

@sufyanAbbasi
Copy link
Contributor

/gcbrun

@shobhitagarwal1612 shobhitagarwal1612 merged commit 2b62677 into google:master Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sufyanAbbasi sufyanAbbasi sufyanAbbasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Code health] Add Unit Test MultipleChoiceItem
3 participants
@anandwana001 @shobhitagarwal1612 @sufyanAbbasi