Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit Test for MapStateRepository #2527

Merged

Conversation

anandwana001
Copy link
Collaborator

Fixes #2526

40% -> 58% Code Coverage

@sufyanAbbasi @shobhitagarwal1612 PTAL?
Should we write test for the delegate property as well? I think the variables setter and getter are already tested and the remaining can be skip, but would like to know your thoughts on this.

Screenshot 2024-06-28 at 15 21 01

@shobhitagarwal1612
Copy link
Member

/gcbrun

@sufyanAbbasi
Copy link
Contributor

Should we write test for the delegate property as well? I think the variables setter and getter are already tested and the remaining can be skip

I think your analysis is correct here, we don't need to unit test those since they are Kotlin features we can assume to just work.

Thank you so much!

@shobhitagarwal1612
Copy link
Member

/gcbrun

@shobhitagarwal1612
Copy link
Member

@anandwana001 Can you please ensure that the checks are passing locally as well?

* What went wrong:
Execution failed for task ':workspace:ground:ktfmtCheckTest'.
> [ktfmt] Found 1 files that are not properly formatted:
  src/test/java/com/google/android/ground/repository/MapStateRepositoryTest.kt

@sufyanAbbasi
Copy link
Contributor

/gcbrun

@sufyanAbbasi
Copy link
Contributor

/gcbrun

@anandwana001
Copy link
Collaborator Author

Passing locally, running again now

@anandwana001
Copy link
Collaborator Author

/gcbrun

@sufyanAbbasi sufyanAbbasi merged commit 1da350c into google:master Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code health] Add unit test for MapStateRepository
3 participants