-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Unit Test for MapStateRepository #2527
Added Unit Test for MapStateRepository #2527
Conversation
/gcbrun |
ground/src/test/java/com/google/android/ground/repository/MapStateRepositoryTest.kt
Outdated
Show resolved
Hide resolved
I think your analysis is correct here, we don't need to unit test those since they are Kotlin features we can assume to just work. Thank you so much! |
/gcbrun |
@anandwana001 Can you please ensure that the checks are passing locally as well?
|
/gcbrun |
/gcbrun |
Passing locally, running again now |
/gcbrun |
Fixes #2526
40% -> 58% Code Coverage
@sufyanAbbasi @shobhitagarwal1612 PTAL?
Should we write test for the delegate property as well? I think the variables setter and getter are already tested and the remaining can be skip, but would like to know your thoughts on this.