Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draw area task] Add support for partial loads of drawn areas (works for completed ones) #2373

Closed
shobhitagarwal1612 opened this issue Mar 16, 2024 · 6 comments · Fixed by #2720
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@shobhitagarwal1612
Copy link
Member

Split from #708

@shobhitagarwal1612
Copy link
Member Author

Remaining item: add support for draw polygon task

@gino-m
Copy link
Collaborator

gino-m commented Jul 30, 2024

Remaining item: add support for draw polygon task

Hi @shobhitagarwal1612, that's the actual scope of the issue. Do you know how much work is involved, eg in terms of # days?

@shobhitagarwal1612
Copy link
Member Author

I think it'll take atleast 1 week

@gino-m
Copy link
Collaborator

gino-m commented Jul 30, 2024

I think it'll take atleast 1 week

1 day @ 20%?

@sufyanAbbasi
Copy link
Contributor

@shobhitagarwal1612 in the above PR said:

This won't work if the drawn area isn't complete, right? My understanding was that we have to persist partial polygon as well, but that was causing some troubles as we create the task data only when the polygon is marked as complete. The current approach is a big improvement over not loading anything at all.

@gino-m Can we confirm that we don't need to re-load partial polygons?

I think we can lower the priority of this feature to P2 to support partial loads.

@sufyanAbbasi sufyanAbbasi removed their assignment Aug 2, 2024
@sufyanAbbasi sufyanAbbasi changed the title [Draw area task] Add support for loading previous value from draft [Draw area task] Add support for partial loads of drawn areas (works for completed ones) Aug 2, 2024
@gino-m
Copy link
Collaborator

gino-m commented Aug 7, 2024

@shobhitagarwal1612 in the above PR said:

This won't work if the drawn area isn't complete, right? My understanding was that we have to persist partial polygon as well, but that was causing some troubles as we create the task data only when the polygon is marked as complete. The current approach is a big improvement over not loading anything at all.

@gino-m Can we confirm that we don't need to re-load partial polygons?

I think we can lower the priority of this feature to P2 to support partial loads.

While being drawn, polygons spend more time being incomplete than complete, in which case the risk is the user will be more likely to have to start over again if they navigate away from Ground for a sec. I'd say this is P1.5, but ok to keep at P2 for now.

@gino-m gino-m modified the milestones: Beta release, GA release Aug 9, 2024
@gino-m gino-m added type: bug Something isn't working and removed type: fr Request for new feature labels Aug 22, 2024
@jcqli jcqli moved this to Todo in Ground Aug 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ground Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants