Mutations Sync: Refactor and filter on current user #2237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two small bits of cleanup in the LocalMutationSyncWorker:
1. Move fetching of mutations eligible for retry into the mutations
repository
2. Only sync mutations associated with the current authenticated user.
Also adds a new test to validate (2.). Progress toward issue google#2235.
9 tasks
gino-m
reviewed
Feb 14, 2024
ground/src/main/java/com/google/android/ground/persistence/sync/MediaUploadWorker.kt
Show resolved
Hide resolved
gino-m
approved these changes
Feb 15, 2024
ground/src/main/java/com/google/android/ground/persistence/sync/LocalMutationSyncWorker.kt
Outdated
Show resolved
Hide resolved
gino-m
approved these changes
Mar 1, 2024
|
Looks like there are detekt errors to correct. |
|
@gino-m FYI should be good to go, holding off on merging just to be sure we manage these correctly before cutting a release |
|
@gino-m FYI — since this is pretty stale, I'm going to close it for now. We can reopen if needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small bits of cleanup in the LocalMutationSyncWorker:
Also adds a new test to validate (2.). Progress toward issue #2235.
@gino-m