Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore "Check failure stack trace" message on LOG(FATAL) #1110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restore "Check failure stack trace" message on LOG(FATAL) #1110

wants to merge 1 commit into from

Commits on Jun 22, 2024

  1. Restore "Check failure stack trace" message on LOG(FATAL) 

    google#1074 refactored some of the code to
enable the failure function to throw.  This made it so when
the LogMessageFatal class was used, the error ended up being printed
differently.

Before:
  LOG_AT_LEVEL(google::LogSeverity::FATAL) << "Crash: Hello world!"; ->

  F20240621 18:12:44.710584 139620827212672 log_demo.cc:16] Crash: Hello world!
  *** Check failure stack trace: ***
      @     0x559e2704711a
      @     0x7efc01fac24a
      @     0x7efc01fac305
      @     0x559e27046dd5
  Aborted

  LOG(FATAL) << "Crash: Hello world!"; ->

  F20240621 18:13:05.760556 140518290856832 log_demo.cc:16] Crash: Hello world!
      @     0x55cdc2475130
      @     0x7fccf6fb324a
      @     0x7fccf6fb3305
      @     0x55cdc2474df5
  Aborted

With this patch, they both produce the same output.

Signed-off-by: Austin Schuh <[email protected]>
    @AustinSchuh
    AustinSchuh committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    039298a View commit details
    Browse the repository at this point in the history