Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel build does not mark includes as system headers #837

Open
joshuarubin opened this issue Jul 6, 2022 · 3 comments
Open

bazel build does not mark includes as system headers #837

joshuarubin opened this issue Jul 6, 2022 · 3 comments
Assignees
@drigz

Comments

@joshuarubin
Copy link

By not using includes in the cc_library for the bazel build, includes are considered local. This poses a problem for tools like clang-tidy that can suppress issues coming from system headers. As a result, our lint output is littered with glog errors.
@drigz
Copy link
Member

drigz commented Jul 8, 2022 •
edited
Loading

e6e2e13 replaced includes with strip_include_prefix. It's a "grab bag" commit, but I believe the relevant explanation is "No longer expose internal headers." Feel free to send a pull request to switch back, but please ensure that downstream targets that do eg #include <stacktrace.h> do not pick up the glog-internal header, since I think this is why the switch was made.

@sfc-gh-ebrossard sfc-gh-ebrossard mentioned this issue Dec 8, 2022
Closed
@sergiud
Copy link
Collaborator

sergiud commented Feb 22, 2023

Is this still an issue?

@drigz
Copy link
Member

drigz commented Feb 23, 2023

I guess so, I'm not aware of a way to avoid the "exposing the private config.h header" without having the effect that the reporter described, although presumably it could be done by rearranging/renaming the source/include files in this repo and adjusting the CMake build accordingly.

@drigz drigz mentioned this issue May 30, 2023
Closed
drigz added a commit that referenced this issue May 31, 2023
@drigz
Warn about dragons in the Bazel include path
0e71d2b 
#837 has caused a couple of
disappointments for PR authors, so I'm hoping this comment can save them
some time, or even help them towards finding a complete solution for the
problem.
@drigz drigz mentioned this issue May 31, 2023
Merged
drigz added a commit that referenced this issue Jun 5, 2023
@drigz
Warn about dragons in the Bazel include path (#927)
3a0d4d2 
#837 has caused a couple of
disappointments for PR authors, so I'm hoping this comment can save them
some time, or even help them towards finding a complete solution for the
problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drigz drigz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set includes for glog headers in Bazel library sfc-gh-ebrossard/glog
3 participants
@joshuarubin @drigz @sergiud