From 456c75bf483c91190c1c643984a34cca0c36c1e6 Mon Sep 17 00:00:00 2001 From: Shuai Zhang Date: Wed, 31 Jul 2024 09:53:15 +0800 Subject: [PATCH] comment: Prevent adding new features to symbolize detection via the preprocessor. According to sergiud, glog project have made a decision moving away from using preprocessor logic. Add a comment to prevent people get confused. --- src/symbolize.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/symbolize.h b/src/symbolize.h index d9ca52ddc..cb79c2da7 100644 --- a/src/symbolize.h +++ b/src/symbolize.h @@ -77,6 +77,8 @@ # error "symbolize.h" was not included correctly. #endif +// INFO(sergiud): Add new features to build system instead of here. +// See GitHub pull request !1114 for a detail discussion. #ifndef GLOG_NO_SYMBOLIZE_DETECTION # ifndef HAVE_SYMBOLIZE // defined by gcc