Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion request of fruit into Conan Center #83

Open
danimtb opened this issue Feb 11, 2019 · 3 comments
Open

Inclusion request of fruit into Conan Center #83

danimtb opened this issue Feb 11, 2019 · 3 comments

Comments

@danimtb
Copy link

danimtb commented Feb 11, 2019

Hi guys!

My name is Daniel and I am one of the https://conan.io developers. I recently reviewed your inclusion request to include the Conan Packages for your library fruit into the central repository Conan Center.

As you may know we are not asking for any requirement for library authors, only to keep in mind that you are responsible for maintaining the uploaded packages.

However, there are some things that might be interesting to do so I would like to give you some suggestions to improve its visibility and distribution:

  • Include the license file of the library: This is important so every user has a copy of the license file whenever a fruit package is installed -> Add a exports = "COPYING" attribute to you conanfile.py
  • Make sure to distribute the license in the packages with this line in the package() method: self.copy("COPYING", dst="licenses", ignore_case=True, keep_path=False).
  • There are outdated from recipe packages uploaded. This means that some package were build with an outdated version of the recipe. See https://docs.conan.io/en/latest/faq/using.html#what-does-outdated-from-recipe-mean-exactly
  • There are no packages for common platforms such as MacOS or clang compiler.
  • Update the metadata in Bintray. This way your package will be easier to find: https://bintray.com/google/fruit/fruit:google

Most of this points are recommendations but please consider including the license in the packages as it is important for the distribution of the library itself.

If you have any question or need help with the changes do not hesitate to ask.

Thanks a lot!

@danimtb
Copy link
Author

danimtb commented Feb 25, 2019

Hi!

Did you have the time to check the points indicated above?
We would be glad to have fruit packages available for Conan

Thanks!

@poletti-marco
Copy link
Contributor

poletti-marco commented Feb 27, 2019 via email

@danimtb
Copy link
Author

danimtb commented Feb 28, 2019

No problem. Ping me with any doubt you may have. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants