Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abseil's string_view fallback handling question #8453

Open
AbrilRBS opened this issue Dec 16, 2024 · 0 comments
Open

Abseil's string_view fallback handling question #8453

AbrilRBS opened this issue Dec 16, 2024 · 0 comments

Comments

@AbrilRBS
Copy link

AbrilRBS commented Dec 16, 2024

Hi!

In Conan Center Index we got a report indicating that Abseil was being picked up, which was unexpected as no find_package for abseil is performed, so a system installed one was being picked up instead of a Conan-provided one, which caused compilation errors for the user. (It's only find_package'ed as part of FLATBUFFERS_BUILD_GRPCTEST, which as far as I can see, it's a distinct path from the above issue, but please correct me if I'm mistaken!)

So we wanted to know if there is a way/plans for a way to completely disable this fallback? (And/or make the Abseil dependency explicit when needed)

PS: In #7897 a check for ABSL_USES_STD_STRING_VIEW was added to avoid some of the compilation errors that this fallback might cause, but as far as I can see, that'd still fail on the OP's case

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant