URLEncoder.encode(String, String) false positive

[rdehuyss]

We're using the following code in our project:

return URLEncoder.encode(string, UTF_8.name());

When using errorprone with gradle we get a warning message that is obsolete. This is not the case however.

Build output

     /jobrunr/core/src/main/java/org/jobrunr/utils/StringUtils.java:112: warning: [JdkObsolete] Use URLEncoder.encode(String, Charset) instead.
            return URLEncoder.encode(string, UTF_8.name());
                                    ^
    (see https://errorprone.info/bugpattern/JdkObsolete)

Our setup:

plugins {
    id 'net.ltgt.errorprone' version '5.1.0' apply false
}

dependencies {
   errorprone 'com.google.errorprone:error_prone_core:2.48.0'
}

[cushon]

The recommendation is to use URLEncoder.encode(string, UTF_8), instead of passing the Charset as a String

[rdehuyss]

The recommendation is to use URLEncoder.encode(string, UTF_8), instead of passing the Charset as a String

I know but this is not possible in JDK 8.

[mirkoalicastro]

Hi @cushon! Same here. I've addressed this with a PR that naturally extends the existing androidMinSdkVersion approach with an analogous jdkVersion field. Could you pls have a look? #5648