Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Reduce memory usage by increasing shared string usage #1820

Open
tst-lsavoie opened this issue Aug 13, 2020 · 2 comments
Open

Reduce memory usage by increasing shared string usage #1820

tst-lsavoie opened this issue Aug 13, 2020 · 2 comments

Comments

@tst-lsavoie
Copy link
Collaborator

We've identified a couple of places that store asset and asset version names but haven't yet been converted to shared strings. Using shared strings in these two places should reduce Fusion memory usage further with minimal effort.

  • in earth_enterprise/src/NATIVE-DBG-x86_64/fusion/autoingest/.idl/storage/InsetStackItem.h, change dataAsset to a SharedString.
  • in earth_enterprise/src/common/verref_storage.h, change _VerRefDef::asset_name to a SharedString.

Note that InsetStackItem.h is an autogenerated file, so you actually need to change the source file.

@zayaanmoez
Copy link

Hi. I would like to work on this.
Are these the only file that require the change?

  • earthenterprise/earth_enterprise/src/fusion/autoingest/storage/InsetStackItem.idl
  • earth_enterprise/src/common/verref_storage.h

Also anything else that i need to do to test this?

@tst-lsavoie
Copy link
Collaborator Author

Thanks for the help @zayaanmoez. After you change those places you may have to make some other changes like calling toString() to convert it to a std::string in some cases. But if you make the changes in those two files and then fix any compile errors that happen I think you'll be good.

For testing, if you can build a database with a few images (like in the Fusion tutorial: http://www.opengee.org/geedocs/5.3.5/answer/fusionTutorial.html) that would certainly be a good start. If you can find a way to add unit tests for the above files, that would be even better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants