Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CMakeLists.txt to accomodate the needs of the community #22

Open
axxel opened this issue May 26, 2022 · 3 comments
Open

update CMakeLists.txt to accomodate the needs of the community #22

axxel opened this issue May 26, 2022 · 3 comments

Comments

@axxel
Copy link

axxel commented May 26, 2022

I am interested in using this project inside zxing-cpp (see zxing-cpp/zxing-cpp#336). I'd very much like to incorporate it via cmake's FetchContent mechanism. This is currently not possible due to the way gtest is setup. A quick look at the network graph revealed that quite a few people felt the need to disable that as well.

Is there any chance that the CMakeLists.txt could be updated with

  • the option of disabling the gtest infrastructure (preferably by default)
  • making sure it builds with cmake without the platform specific shell script autogen.sh
  • an update of the required minimum cmake version to something more adequately representing the current landscape (fixing deprecation warnings)?
@axxel axxel changed the title update CMakeLists.txt to accomodate the needs of the comminty update CMakeLists.txt to accomodate the needs of the community May 26, 2022
@azgotcha
Copy link

azgotcha commented May 26, 2022 via email

@axxel
Copy link
Author

axxel commented May 27, 2022

  • the build fails with the error message No rule to make target '/home/axel/contrib/zxing-cpp.git/gtest/lib/libgtest.a', needed by 'bin/ced_unittest'. Stop.
  • the configure step complains about Compatibility with CMake < 2.8.12 will be removed from a future version of CMake.

@axxel
Copy link
Author

axxel commented Jun 9, 2022

Is there anything else I can do to help move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants