Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

[question/request] output_metrics_options availability HTTP probe #295

Closed
jbkc85 opened this issue Oct 22, 2019 · 2 comments
Closed

[question/request] output_metrics_options availability HTTP probe #295

jbkc85 opened this issue Oct 22, 2019 · 2 comments

Comments

@jbkc85
Copy link

jbkc85 commented Oct 22, 2019

To whom it may concern,

I was wanting to use output_metrics_options in the HTTP probe but apparently its only available in the external type. Is there a reason for this? I would love to be able to add additional tags to whatever probe type i can - specifically environment without having to write Prometheus regex labels.

Thanks!

ie:

  http_probe {
    protocol: HTTPS
    output_metrics_options {
      additional_labels: "environment=location1,service=example"
    }
  }
@jbkc85 jbkc85 changed the title [QUESTION/REQUEST] output_metrics_options availability HTTP probe [question/request] output_metrics_options availability HTTP probe Oct 22, 2019
@manugarg
Copy link
Contributor

@jbkc85 If you're looking for output_metrics_options only for additional labels, there is another way to do it (though it's not released yet):

// Additional labels to add to the probe results. Label's value can either be
// static or can be derived from target's labels.
//
// Example:
// additional_label {
// key: "src_zone"
// value: "{{.zone}}"
// }
// additional_label {
// key: "src_zone"
// value: "target.labels.zone"
// }
repeated AdditionalLabel additional_label = 14;

Though I understand that output_metrics_options can be useful for HTTP probes regardless in case you want to parse metrics from HTTP probe output.

@manugarg
Copy link
Contributor

I just released a new version v0.10.5 that has support for the additional_label field. Also added an example. Since this particular issue seems to be just about that, marking it closed. I've file a different feature request to build metrics from the HTTP probe output: #297.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants