No public description

PiperOrigin-RevId: 753181562

Author: ckennelly

base/attribute.cc

@@ -206,7 +206,7 @@ bool AttributeQualifier::operator<(const AttributeQualifier& other) const {
 bool Attribute::operator==(const Attribute& other) const {
   // We cannot check pointer equality as a short circuit because we have to
   // treat all invalid AttributeQualifier as not equal to each other.
-  // TODO we only support Ident-rooted attributes at the moment.
+  // TODO(issues/41) we only support Ident-rooted attributes at the moment.
   if (variable_name() != other.variable_name()) {
     return false;
   }

base/attribute.h

@@ -124,7 +124,7 @@ class AttributeQualifier final {
 
 // AttributeQualifierPattern matches a segment in
 // attribute resolutuion path. AttributeQualifierPattern is capable of
-// matching path elements of types string/int64_t/uint64/bool.
+// matching path elements of types string/int64/uint64/bool.
 class AttributeQualifierPattern final {
  private:
   // Qualifier value. If not set, treated as wildcard.

base/function_result.h

@@ -50,7 +50,7 @@ class FunctionResult final {
     return descriptor() == other.descriptor();
   }
 
-  // TODO: re-implement argument capture
+  // TODO(uncreated-issue/5): re-implement argument capture
 
  private:
   FunctionDescriptor descriptor_;

checker/checker_options.h

@@ -32,7 +32,7 @@ struct CheckerOptions {
   // types, durations, timestamps, and any types. This is inconsistent with
   // CEL's usual interpretation of null as a literal JSON null.
   //
-  // TODO: Need a concrete plan for updating existing CEL
+  // TODO(uncreated-issue/75): Need a concrete plan for updating existing CEL
   // expressions that depend on the old behavior.
   bool enable_legacy_null_assignment = true;
 

checker/internal/type_checker_impl.cc

@@ -123,7 +123,7 @@ bool IsPbNullFieldAssignable(const Type& value, const Type& field) {
 // Flatten the type to the AST type representation to remove any lifecycle
 // dependency between the type check environment and the AST.
 //
-// TODO: It may be better to do this at the point of serialization
+// TODO(uncreated-issue/72): It may be better to do this at the point of serialization
 // in the future, but requires corresponding change for the runtime to correctly
 // rehydrate the serialized Ast.
 absl::StatusOr<AstType> FlattenType(const Type& type);
@@ -598,7 +598,7 @@ void ResolveVisitor::PostVisitMap(const Expr& expr, const MapExpr& map) {
   // homogeneously typed, otherwise assume the type parameter is dyn (defer to
   // runtime for enforcing type compatibility).
   //
-  // TODO: Widening behavior is not well documented for map / list
+  // TODO(uncreated-issue/72): Widening behavior is not well documented for map / list
   // construction in the spec and is a bit inconsistent between implementations.
   //
   // In the future, we should probably default enforce homogeneously
@@ -1222,7 +1222,7 @@ class ResolveRewriter : public AstRewriterBase {
       auto& ast_ref = reference_map_[expr.id()];
       ast_ref.set_name(decl->name());
       for (const auto& overload : decl->overloads()) {
-        // TODO: narrow based on type inferences and shape.
+        // TODO(uncreated-issue/72): narrow based on type inferences and shape.
         ast_ref.mutable_overload_id().push_back(overload.id());
       }
       expr.mutable_call_expr().set_function(decl->name());

checker/internal/type_inference_context.cc

@@ -49,7 +49,7 @@ bool IsWildCardType(Type type) {
 // Historically, structs and abstract types were considered nullable. This is
 // inconsistent with CEL's usual interpretation of null as a literal JSON null.
 //
-// TODO: Need a concrete plan for updating existing CEL expressions
+// TODO(uncreated-issue/74): Need a concrete plan for updating existing CEL expressions
 // that depend on the old behavior.
 bool IsLegacyNullable(Type type) {
   switch (type.kind()) {

checker/internal/type_inference_context.h

@@ -34,7 +34,7 @@
 namespace cel::checker_internal {
 
 // Class manages context for type inferences in the type checker.
-// TODO: for now, just checks assignability for concrete types.
+// TODO(uncreated-issue/72): for now, just checks assignability for concrete types.
 // Support for finding substitutions of type parameters will be added in a
 // follow-up CL.
 class TypeInferenceContext {

checker/internal/type_inference_context_test.cc

@@ -208,7 +208,7 @@ TEST(TypeInferenceContextTest, InstantiateTypeParamsOpaque) {
                           IsTypeParam("T%2"), IsTypeParam("T%1")));
 }
 
-// TODO: Does not consider any substitutions based on type
+// TODO(uncreated-issue/72): Does not consider any substitutions based on type
 // inferences yet.
 TEST(TypeInferenceContextTest, OpaqueTypeAssignable) {
   google::protobuf::Arena arena;

checker/standard_library.cc

@@ -845,7 +845,7 @@ absl::Status AddTypeConstantVariables(TypeCheckerBuilder& builder) {
 absl::Status AddEnumConstants(TypeCheckerBuilder& builder) {
   VariableDecl pb_null;
   pb_null.set_name("google.protobuf.NullValue.NULL_VALUE");
-  // TODO: This is interpreted as an enum (int) or null in
+  // TODO(uncreated-issue/74): This is interpreted as an enum (int) or null in
   // different cases. We should add some additional spec tests to cover this and
   // update the behavior to be consistent.
   pb_null.set_type(IntType());

checker/standard_library_test.cc

@@ -242,7 +242,7 @@ class StdLibDefinitionsTest
 // This is not intended to be exhaustive since it is expected to be covered by
 // spec conformance tests.
 //
-// TODO: Tests are fairly minimal right now -- it's not possible to
+// TODO(uncreated-issue/72): Tests are fairly minimal right now -- it's not possible to
 // test thoroughly without a more complete implementation of the type checker.
 // Type-parameterized functions are not yet checkable.
 TEST_P(StdLibDefinitionsTest, Runner) {