Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous toolbox plugin for flyout API changes #2464

Open
1 task done
gonfunko opened this issue Oct 7, 2024 · 1 comment · May be fixed by #2468
Open
1 task done

Update continuous toolbox plugin for flyout API changes #2464

gonfunko opened this issue Oct 7, 2024 · 1 comment · May be fixed by #2468
Labels
type: bug Something isn't working
Milestone

Comments

@gonfunko
Copy link
Contributor

gonfunko commented Oct 7, 2024

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

Continuous Toolbox plugin

Description

The flyout API is changing in Blockly v12 (see google/blockly#8601), and the continuous toolbox plugin will need to be updated for compatibility. Most of the needed changes have already been made in gonfunko/scratch-blocks#209 (review) and will just need to be backported, but we'll need to coordinate merging/publishing to coincide with the v12 release.

Reproduction steps

No response

Stack trace

No response

Screenshots

No response

@gonfunko
Copy link
Contributor Author

gonfunko commented Oct 7, 2024

ContinuousToolbox.getInitialFlyoutContents_() should also be refactored to allow subclasses to make changes. It should probably call a conversion function for each item, which subclasses could override to support additional types of flyout items or just delegate to super.

@cpcallen cpcallen added this to the Upcoming milestone Oct 11, 2024
@cpcallen cpcallen removed the triage label Oct 11, 2024
@gonfunko gonfunko linked a pull request Nov 8, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants