Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't visit contents of non-visible inputs #269

Open
microbit-matt-hillsdon opened this issue Mar 4, 2025 · 1 comment
Open

Don't visit contents of non-visible inputs #269

microbit-matt-hillsdon opened this issue Mar 4, 2025 · 1 comment

Comments

@microbit-matt-hillsdon
Copy link
Contributor

microbit-matt-hillsdon commented Mar 4, 2025 •
edited
Loading

MakeCode has blocks that use progressive disclosure to hide fields but the keyboard navigation will happily visit the non-visible inputs.

State before the hidden input:
Image

After pressing right there is no visible cursor:
Image

Expanded via + button to show hidden input
Image

Not needed for user testing.

The click handlers for the +/- buttons bottom out at input.setVisible.
@microbit-matt-hillsdon
Copy link
Contributor Author

Not sure this can be fixed in the plugin as the input's connection is on the ASTNode rather than the input itself. See ASTNode.findFirstFieldOrInput in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@microbit-matt-hillsdon