Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No visual indication when keyboard navigation disabled #92

Open
cpcallen opened this issue Nov 8, 2024 · 0 comments · May be fixed by #226
Open

No visual indication when keyboard navigation disabled #92

cpcallen opened this issue Nov 8, 2024 · 0 comments · May be fixed by #226
Assignees

Comments

@cpcallen
Copy link
Contributor

cpcallen commented Nov 8, 2024

At the moment, when you press 'enter' to enable keyboard navigation the cursor appears, but there is no corresponding visual indication when keyboard navigation is disabled (i.e. you press 'esc').

There should be a clear visible change when keyboard navigation is disabled; at minimum, the cursor should be hidden.

Currently we are using block selection as the main visual indication the cursor is on a block. If we continue to do that we should have an additional visual indicator (e.g. a small arrow) to denote focus; this additional indicator can be hidden even if the block remains selected (and would additionally distinguish the focused block in the event that multiselect is supported).

In the event that we continue to oblige use of enter/esc to enable and disable keyboard navigation, pressing esc should not result in the workspace focus indicator (blue / black outline) disappearing—in fact, perhaps it should reappear when esc is pressed, having previous disappeared (in favour of the cursor) when enter was pressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants