Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Font-Family Should be configable #22

Open
tylzh97 opened this issue Sep 27, 2023 · 3 comments
Open

UI: Font-Family Should be configable #22

tylzh97 opened this issue Sep 27, 2023 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@tylzh97
Copy link

tylzh97 commented Sep 27, 2023

Describe the bug
Some characters are not displayed properly. Because bindiff trying to use Roboto Mono as the only font, However this font family doesn't support non-ASCII characters. Maybe font-family config can be add into config>main settings>general card.

To Reproduce
Just Open it and open any config window.

Screenshots
image

Environment (please complete the following information):

  • OS and version: Windows 10
  • Locale: zh-CN (Simplified Chinese)
  • Disassembler and version: IDA Pro 7.1

Additional context
Add any other context about the problem here.

@cblichmann
Copy link
Member

Oh wow. Sorry for that. We really only support (and test) US English as the locale.

As a workaround, try setting the font in the config file (in %AppData%\Roaming\BinDiff\bindiff.json):
Screenshot 2023-09-27 at 08 56 21

Setting this to "Segoe UI" for example, works for setting the UI font, but the core problem is that the Java runtime does not have a concept of fallback fonts if characters needed for a locale are not available.

Setting the font to "SimSun" looks ugly for western text, but seems to work (I don't know any Chinese...):
Screenshot 2023-09-27 at 09 17 58

@cblichmann cblichmann added bug Something isn't working enhancement New feature or request labels Sep 27, 2023
@tylzh97
Copy link
Author

tylzh97 commented Sep 27, 2023

Thanks very much! It works for me. And may I ask are there any plans to include font configuration in the configuration menu in a future release?

@cblichmann
Copy link
Member

I don't see why not. It'd be good to revamp the settings dialog anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants