@@ -22,7 +22,6 @@ limitations under the License.
2222#include < vector>
2323
2424#include " absl/status/status.h"
25- #include " absl/strings/match.h"
2625#include " absl/strings/str_format.h"
2726#include " absl/strings/string_view.h"
2827#include " cpp/array_record_reader.h"
@@ -35,8 +34,6 @@ limitations under the License.
3534#include " riegeli/base/maker.h"
3635#include " riegeli/bytes/fd_reader.h"
3736#include " riegeli/bytes/fd_writer.h"
38- #include " riegeli/gcs/gcs_object.h"
39- #include " riegeli/gcs/gcs_reader.h"
4037
4138namespace py = pybind11;
4239
@@ -53,13 +50,10 @@ PYBIND11_MODULE(array_record_module, m) {
5350 throw py::value_error (
5451 std::string (status_or_option.status ().message ()));
5552 }
56- riegeli::FdWriterBase::Options file_writer_options;
57- file_writer_options.set_buffer_size (size_t {16 } << 20 );
5853 // Release the GIL because IO is time consuming.
5954 py::gil_scoped_release scoped_release;
6055 return new array_record::ArrayRecordWriter (
61- riegeli::Maker<riegeli::FdWriter>(
62- path, std::move (file_writer_options)),
56+ riegeli::Maker<riegeli::FdWriter>(path),
6357 status_or_option.value ());
6458 }),
6559 py::arg (" path" ), py::arg (" options" ) = " " )
@@ -90,29 +84,18 @@ PYBIND11_MODULE(array_record_module, m) {
9084 std::string (status_or_option.status ().message ()));
9185 }
9286 riegeli::FdReaderBase::Options file_reader_options;
93- riegeli::GcsReader::Options gcs_reader_options;
9487 if (kwargs.contains (" file_reader_buffer_size" )) {
9588 auto file_reader_buffer_size =
9689 kwargs[" file_reader_buffer_size" ].cast <int64_t >();
9790 file_reader_options.set_buffer_size (file_reader_buffer_size);
98- gcs_reader_options.set_buffer_size (file_reader_buffer_size);
9991 }
10092 // Release the GIL because IO is time consuming.
10193 py::gil_scoped_release scoped_release;
102- if (absl::StartsWith (path, " gs://" )) {
103- return new array_record::ArrayRecordReader (
104- riegeli::Maker<riegeli::GcsReader>(
105- google::cloud::storage::Client (),
106- riegeli::GcsObject (path), std::move (gcs_reader_options)),
107- status_or_option.value (),
108- array_record::ArrayRecordGlobalPool ());
109- } else {
110- return new array_record::ArrayRecordReader (
111- riegeli::Maker<riegeli::FdReader>(
112- path, std::move (file_reader_options)),
113- status_or_option.value (),
114- array_record::ArrayRecordGlobalPool ());
115- }
94+ return new array_record::ArrayRecordReader (
95+ riegeli::Maker<riegeli::FdReader>(
96+ path, std::move (file_reader_options)),
97+ status_or_option.value (),
98+ array_record::ArrayRecordGlobalPool ());
11699 }),
117100 py::arg (" path" ), py::arg (" options" ) = " " , R"(
118101 ArrayRecordReader for fast sequential or random access.
0 commit comments