Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Finding the product for coverage easily breaks #17

Open
Mazyod opened this issue Aug 18, 2017 · 1 comment
Open

Finding the product for coverage easily breaks #17

Mazyod opened this issue Aug 18, 2017 · 1 comment

Comments

@Mazyod
Copy link
Contributor

Mazyod commented Aug 18, 2017

Hey,

In the engine code, there is a find command that can easily break if the framework was already built for another target:

$future = new ExecFuture("find %C | grep %C", $objroot, $this->coverage['product']);

I'm trying to find a good fix for this... perhaps by checking the returned paths for CodeCoverage

@Mazyod
Copy link
Contributor Author

Mazyod commented Aug 18, 2017

I fixed the issue locally using:

    foreach ($this->xcodebuild as $key => $value) {
      ...
      if ($key == "sdk") {
        $product_sdk = $value;
      }
      if ($key == "configuration") {
        $product_configuration = $value;
      }
      ...
    }
    ...
      $platform_path = "$product_configuration-$product_sdk";
      $product_location = "CodeCoverage/Products/$platform_path/" . $this->coverage['product'];
      $future = new ExecFuture("find %C | grep %C", $objroot, $product_location);

Looks pretty hacky ... let me know your thoughts. (cc @hossamghareeb)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant