Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan validation layer error when running latest #1062

Open
Zhaeong opened this issue Dec 11, 2024 · 2 comments
Open

Vulkan validation layer error when running latest #1062

Zhaeong opened this issue Dec 11, 2024 · 2 comments
Assignees

Comments

@Zhaeong
Copy link

Zhaeong commented Dec 11, 2024

With latest when running it locally I'm getting:

./amber
[ERROR] validation layer (Validation):
Validation Error: [ VUID-VkDeviceCreateInfo-pNext-pNext ] Object 0: handle = 0x5e4978bc0d30, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x901f59ec | vkCreateDevice(): pCreateInfo->pNext<VkPhysicalDeviceShaderFloat16Int8Features> includes a pointer to a VkPhysicalDeviceShaderFloat16Int8Features, but when creating VkDevice, the parent extension (VK_KHR_shader_float16_int8) was not included in ppEnabledExtensionNames.
The Vulkan spec states: Each pNext member of any structure (including this one) in the pNext chain must be either NULL or a pointer to a valid struct for extending VkDeviceCreateInfo (https://vulkan.lunarg.com/doc/view/1.3.296.0/linux/1.3-extensions/vkspec.html#VUID-VkDeviceCreateInfo-pNext-pNext)
[ERROR] validation layer (Validation):
Validation Error: [ VUID-VkDeviceCreateInfo-pNext-pNext ] Object 0: handle = 0x5e4978bc0d30, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x901f59ec | vkCreateDevice(): pCreateInfo->pNext<VkPhysicalDevice8BitStorageFeatures> includes a pointer to a VkPhysicalDevice8BitStorageFeatures, but when creating VkDevice, the parent extension (VK_KHR_8bit_storage) was not included in ppEnabledExtensionNames.
The Vulkan spec states: Each pNext member of any structure (including this one) in the pNext chain must be either NULL or a pointer to a valid struct for extending VkDeviceCreateInfo (https://vulkan.lunarg.com/doc/view/1.3.296.0/linux/1.3-extensions/vkspec.html#VUID-VkDeviceCreateInfo-pNext-pNext)
[ERROR] validation layer (Validation):
Validation Error: [ VUID-VkDeviceCreateInfo-pNext-pNext ] Object 0: handle = 0x5e4978bc0d30, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0x901f59ec | vkCreateDevice(): pCreateInfo->pNext<VkPhysicalDeviceBufferDeviceAddressFeatures> includes a pointer to a VkPhysicalDeviceBufferDeviceAddressFeatures, but when creating VkDevice, the parent extension (VK_KHR_buffer_device_address) was not included in ppEnabledExtensionNames.
The Vulkan spec states: Each pNext member of any structure (including this one) in the pNext chain must be either NULL or a pointer to a valid struct for extending VkDeviceCreateInfo (https://vulkan.lunarg.com/doc/view/1.3.296.0/linux/1.3-extensions/vkspec.html#VUID-VkDeviceCreateInfo-pNext-pNext)

Summary: 0 pass, 0 fail

It seems to require adding these lines:
exts.push_back(VK_KHR_SHADER_FLOAT16_INT8_EXTENSION_NAME);
exts.push_back(VK_KHR_8BIT_STORAGE_EXTENSION_NAME);
exts.push_back(VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME);

to this line prior to vulkan device creation:
https://github.com/google/amber/blob/main/samples/config_helper_vulkan.cc#L1216

@Flakebi
Copy link
Contributor

Flakebi commented Dec 11, 2024

This is a regression. I bisected it to #1050 from @petermcneeleychromium

@petermcneeleychromium
Copy link
Collaborator

I suspect the change is actually correct it just has knock on behaviors.
I can take ownership of this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants