From db11921beed3e570b7e0236661e6c6030edc8ddb Mon Sep 17 00:00:00 2001 From: kavinkumarbaskar Date: Sat, 3 May 2025 14:17:41 +0530 Subject: [PATCH 1/6] fix readme pip install --- CONTRIBUTING.md | 5 ++++- .../openapi_tool/openapi_spec_parser/operation_parser.py | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0cee99f7..32765648 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,14 +34,17 @@ This project follows ```shell python -m venv .venv + source .venv/bin/activate + source .\.venv\Scripts\activate [windows] + pip install uv ``` 3. **Install dependencies:** ```shell - uv pip install -e .[dev,test,extensions,eval] + uv pip install -e ".[dev,test,extensions,eval]" ``` 4. **Run unit tests:** diff --git a/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py b/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py index 7c78eee4..794f914d 100644 --- a/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py +++ b/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py @@ -76,7 +76,11 @@ def _process_operation_parameters(self): description = param.description or '' location = param.in_ or '' schema = param.schema_ or {} # Use schema_ instead of .schema - schema.description = description if schema.description is None and description != '' else schema.description + schema.description = ( + description + if schema.description is None and description != '' + else schema.description + ) required = param.required self.params.append( @@ -85,7 +89,7 @@ def _process_operation_parameters(self): param_location=location, param_schema=schema, description=description, - required=required + required=required, ) ) From 5eabc6c1fe339e87637b9ed6d0516a3edcbcb060 Mon Sep 17 00:00:00 2001 From: kavinkumarbaskar Date: Sat, 3 May 2025 14:17:41 +0530 Subject: [PATCH 2/6] fix readme pip install --- CONTRIBUTING.md | 5 ++++- .../openapi_tool/openapi_spec_parser/operation_parser.py | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0cee99f7..32765648 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,14 +34,17 @@ This project follows ```shell python -m venv .venv + source .venv/bin/activate + source .\.venv\Scripts\activate [windows] + pip install uv ``` 3. **Install dependencies:** ```shell - uv pip install -e .[dev,test,extensions,eval] + uv pip install -e ".[dev,test,extensions,eval]" ``` 4. **Run unit tests:** diff --git a/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py b/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py index 7c78eee4..794f914d 100644 --- a/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py +++ b/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py @@ -76,7 +76,11 @@ def _process_operation_parameters(self): description = param.description or '' location = param.in_ or '' schema = param.schema_ or {} # Use schema_ instead of .schema - schema.description = description if schema.description is None and description != '' else schema.description + schema.description = ( + description + if schema.description is None and description != '' + else schema.description + ) required = param.required self.params.append( @@ -85,7 +89,7 @@ def _process_operation_parameters(self): param_location=location, param_schema=schema, description=description, - required=required + required=required, ) ) From bb21018aea7a4b8d8a60e6ef42b084dae51d7845 Mon Sep 17 00:00:00 2001 From: kavinkumarbaskar Date: Sun, 4 May 2025 00:01:42 +0530 Subject: [PATCH 3/6] fix: added build and local testing command --- CONTRIBUTING.md | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 32765648..50a3c203 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,7 +44,7 @@ This project follows 3. **Install dependencies:** ```shell - uv pip install -e ".[dev,test,extensions,eval]" + uv pip install -e .[dev,test,extensions,eval] ``` 4. **Run unit tests:** @@ -57,6 +57,19 @@ This project follows uv run pyink --config pyproject.toml ./src ``` +6. **Build the package** + ```shell + uv build + ``` + +7. **Local Testing** + Have a simple testing folder setup as mentioned in the [quickstart](https://google.github.io/adk-docs/get-started/quickstart/) + then install the local package with changes after building it using the below command to test the changes. + + ```shell + uv pip install /dist/google_adk-0.4.0-py3-none-any.whl + ``` + ### Requirement for PRs - All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one. From aa1f2305b098b79480eab9ab37b744d0273a5fcf Mon Sep 17 00:00:00 2001 From: kavinkumarbaskar Date: Sun, 4 May 2025 00:38:54 +0530 Subject: [PATCH 4/6] fix: added example --- CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 50a3c203..41677210 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -67,7 +67,9 @@ This project follows then install the local package with changes after building it using the below command to test the changes. ```shell - uv pip install /dist/google_adk-0.4.0-py3-none-any.whl + uv pip install + + [eg]: uv pip install /dist/google_adk-0.4.0-py3-none-any.whl ``` ### Requirement for PRs From 69b649d81e6757d6305c481e3415ec8f017a75ac Mon Sep 17 00:00:00 2001 From: kavinkumarbaskar Date: Tue, 6 May 2025 23:13:44 +0530 Subject: [PATCH 5/6] fix: updated the windows command --- CONTRIBUTING.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dedce9bb..c294d3ed 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -112,10 +112,18 @@ For any changes that impact user-facing documentation (guides, API reference, tu ```shell python -m venv .venv - + ``` + + ```shell source .venv/bin/activate - source .\.venv\Scripts\activate [windows] + ``` + + **windows** + ```shell + source .\.venv\Scripts\activate + ``` + ```shell pip install uv ``` From bd5202308bf08b9b44099c4cd016af23f2e2350e Mon Sep 17 00:00:00 2001 From: kavinkumarbaskar Date: Tue, 6 May 2025 23:17:00 +0530 Subject: [PATCH 6/6] fix: removed redundant code --- CONTRIBUTING.md | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c294d3ed..baf5c167 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -158,19 +158,6 @@ For any changes that impact user-facing documentation (guides, API reference, tu [eg]: uv pip install /dist/google_adk-0.4.0-py3-none-any.whl ``` -### Requirement for PRs - -- All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one. -- Small, focused PRs. Keep changes minimal—one concern per PR. -- For bug fixes or features, please provide logs or screenshot after the fix is applied to help reviewers better understand the fix. -- Please add corresponding testing for your code change if it's not covered by existing tests. - -### Large or Complex Changes -For substantial features or architectural revisions: - -- Open an Issue First: Outline your proposal, including design considerations and impact. -- Gather Feedback: Discuss with maintainers and the community to ensure alignment and avoid duplicate work - ### Code reviews All submissions, including submissions by project members, require review. We