Skip to content

fix(comment): malicious user cannot obtain another user’s session #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(comment): malicious user cannot obtain another user’s session #1959

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45ce66a
fix(comment): malicious user cannot obtain another user’s session
mthorme Jul 14, 2025
97e1182
Merge branch 'main' into fix-comment-session-mismatch
wyf7107 Jul 15, 2025
b1f139a
Merge branch 'main' into fix-comment-session-mismatch
mthorme Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/unittests/sessions/test_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ async def test_session_state(service_type):
assert session_11.state.get('user:key1') == 'value1'
assert not session_11.state.get('temp:key')

# Make sure a malicious user can obtain a session and events not belonging to them
# Make sure a malicious user cannot obtain a session and events not belonging to them
session_mismatch = await session_service.get_session(
app_name=app_name, user_id=user_id_malicious, session_id=session_id_11
)
Expand Down