set the version number somewhere #162
Conversation
Fix google#161 My understanding of the problem is that the version number is not set anywhere. pyproject.toml uses a dynamic version number but the dynamic estination is not set, xee package has no __version__ variable. the one in `ext` is using the one from metadata which relies on the pyproject file. I decided to start this PR by setting where the dynamic version number should come from. Now I need your review to know where the hard coded version number should be set.
|
Thanks Pierrick! |
|
Should I change anything to see this PR merged ? |
| version = {attr = "xee.__version__"} | ||
|
|
||
| [tool.setuptools_scm] |
There was a problem hiding this comment.
I'm not sure we should take this approach. Can we try generating the version file with setuptools_scm instead?
https://github.com/pypa/setuptools-scm
[tool.setuptools_scm]
version_file = "pkg/_version.py"
Will that fix the issue with conda that lead to this patch?
There was a problem hiding this comment.
I never use setuptools_scm, I personnaly use commitizen to generate the version numbers. I think from conda the version number needs to exist at least in 1 place that does not require to load the modules. If this does the job as well I'm happy with it, I just don't know how to test it if not doing patch releases to conda-forge.
There was a problem hiding this comment.
I wonder how other folks solve this problem. I'd like to keep using setuptools_scm if possible and not have two places where that is traced (version control and code). It looks like Xarray does something similar. Maybe, to address the conda issue, we could do what they do and set a fallback version?
https://github.com/pydata/xarray/blob/1c6300c415efebac15f5ee668a3ef6419dbeab63/pyproject.toml#L70
There was a problem hiding this comment.
Let me do that in another PR and see if it works
Fix #161
My understanding of the problem is that the version number is not set anywhere.
pyproject.toml uses a dynamic version number but the dynamic estination is not set, xee package has no version variable. the one in
extis using the one from metadata which relies on the pyproject file.I decided to start this PR by setting where the dynamic version number should come from. Now I need your review to know where the hard coded version number should be set.