-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More properties for CameraSpec (focal, fov,...) #13
Labels
Comments
I would like to take up this task. |
Thanks @Achint08 . Feel free to send us a PR! |
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Achint08
added a commit
to Achint08/visu3d
that referenced
this issue
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CameraSpec
/PinholeCamera
could have additional properties like:spec.focal_px_wh
: Returns the(fw, fh)
focal length (in px)spec.focal_px
: Returns the unique focal (when fw == fh). Implementation could be inspired fromv3d.Transform.scale
property: https://github.com/google-research/visu3d/pull/10/files#diff-6402e17c4cd486883434c2847d32baaac9b36f95fd76d3969852d7276645778dspec.fov
: Returns the field of viewBecause the fields can vary across each camera, maybe the fields should return a property to allow selecting sub-fields, like:
Not sure about the
.unique
,.value
name thoughThe text was updated successfully, but these errors were encountered: