Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More properties for CameraSpec (focal, fov,...) #13

Open
Conchylicultor opened this issue May 4, 2022 · 2 comments
Open

More properties for CameraSpec (focal, fov,...) #13

Conchylicultor opened this issue May 4, 2022 · 2 comments

Comments

@Conchylicultor
Copy link
Collaborator

Conchylicultor commented May 4, 2022

CameraSpec/PinholeCamera could have additional properties like:

Because the fields can vary across each camera, maybe the fields should return a property to allow selecting sub-fields, like:

spec.focal_px  # FocalInfo[*s]
spec.focal_px.hw  # FloatArray[*s 2]
spec.focal_px.wh  # FloatArray[*s 2]
spec.focal_px.value  # FloatArray[*s]
# And also add option to remove the `*s` dimension ?
spec.focal_px.unique.wh  # FloatArray[2]

Not sure about the .unique, .value name though

@Achint08
Copy link
Contributor

Achint08 commented May 4, 2022

I would like to take up this task.

@Conchylicultor
Copy link
Collaborator Author

Thanks @Achint08 . Feel free to send us a PR!

Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Achint08 added a commit to Achint08/visu3d that referenced this issue May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants