Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefers column/row is broken #15

Closed
vyeevani opened this issue Aug 7, 2024 · 3 comments
Closed

Prefers column/row is broken #15

vyeevani opened this issue Aug 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@vyeevani
Copy link

vyeevani commented Aug 7, 2024

Prefers column/row is currently broken in the ArrayAutoVisualizer

    row_axes = []
    column_axes = []
    for info in array_axis_info:
      if isinstance(info, NamedPositionalAxisInfo | NamedPositionlessAxisInfo):
        if info.axis_name in self.prefers_column:
          column_axes.append(info.axis_name)
        elif info.axis_name in self.prefers_row:
          row_axes.append(info.axis_name)

should be

    row_axes = []
    column_axes = []
    for info in array_axis_info:
      if isinstance(info, NamedPositionalAxisInfo | NamedPositionlessAxisInfo):
        if info.axis_name in self.prefers_column:
          column_axes.append(info)
        elif info.axis_name in self.prefers_row:
          row_axes.append(info)
@vyeevani
Copy link
Author

vyeevani commented Aug 7, 2024

Opened PR: #17

@danieldjohnson
Copy link
Collaborator

Good catch, thanks!

@danieldjohnson danieldjohnson added the bug Something isn't working label Aug 8, 2024
@danieldjohnson
Copy link
Collaborator

I've fixed the original issue in release 0.1.3. (I've left #17 open since it seems like it has some other changes in it as well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants