From a contributor: Fix various compile warnings about questionable code

Author: juddmon

jpilot-dump.c

@@ -776,6 +776,8 @@ static int dumptodo(void)
 
    al = NULL;
    num = get_todos(&al, SORT_ASCENDING);
+   if (num == 0)
+      return (0);
 
    for (tal=al; tal; tal = tal->next) {
       if ((tal->mtodo.rt != DELETED_PALM_REC) && 
@@ -1037,6 +1039,8 @@ static int dumpmemo(void)
    al = NULL;
    i = 0;
    num = get_memos(&al, i);
+   if (num == 0)
+      return (0);
 
    for (tal=al; tal; tal = tal->next) {
       if ((tal->mmemo.rt != DELETED_PALM_REC) && 

jpilot-sync.c

@@ -112,8 +112,7 @@ int main(int argc, char *argv[])
    /* enable internationalization(i18n) before printing any output */
 #if defined(ENABLE_NLS)
 #  ifdef HAVE_LOCALE_H
-      char *current_locale;
-      current_locale = setlocale(LC_ALL, "");
+      setlocale(LC_ALL, "");
 #  endif
    bindtextdomain(EPN, LOCALEDIR);
    textdomain(EPN);

jpilot.c

@@ -1538,11 +1538,6 @@ int main(int argc, char *argv[])
 #endif
    int pid;
    int remote_sync = FALSE;
-#if defined(ENABLE_NLS)
-#  ifdef HAVE_LOCALE_H
-   char *current_locale;
-#  endif
-#endif
 
    skip_plugins=FALSE;
    skip_past_alarms=FALSE;
@@ -1561,7 +1556,7 @@ int main(int argc, char *argv[])
    /* enable internationalization(i18n) before printing any output */
 #if defined(ENABLE_NLS)
 #  ifdef HAVE_LOCALE_H
-      current_locale = setlocale(LC_ALL, "");
+      setlocale(LC_ALL, "");
 #  endif
    bindtextdomain(EPN, LOCALEDIR);
    textdomain(EPN);

libplugin.c

@@ -318,7 +318,6 @@ int jp_pc_write(const char *DB_name, buf_rec *br)
    FILE *out;
    unsigned int next_unique_id;
    unsigned char packed_header[256];
-   int len;
    char PC_name[FILENAME_MAX];
 
    g_snprintf(PC_name, sizeof(PC_name), "%s.pc3", DB_name);
@@ -343,7 +342,7 @@ int jp_pc_write(const char *DB_name, buf_rec *br)
    header.rt=br->rt;
    header.attrib=br->attrib;
 
-   len = pack_header(&header, packed_header);
+   pack_header(&header, packed_header);
    write_header(out, &header);
    fwrite(br->buf, header.rec_len, 1, out);
 
@@ -756,9 +755,7 @@ static void jp_unpack_ntohl(unsigned long *l, unsigned char *src)
 static int pack_header(PC3RecordHeader *header, unsigned char *packed_header)
 {
    unsigned char *p;
-   unsigned long l;
 
-   l=0;
    p=packed_header;
    /*
     * Header structure:

memo_gui.c

@@ -621,7 +621,7 @@ static void cb_memo_export_ok(GtkWidget *export_window, GtkWidget *clist,
             len=strlen(mmemo->memo.text) * 2 + 4;
          }
          if (len<256) len=256;
-	 printf("\"RAW %d %s\"\n", mmemo->attrib & 0x0F, memo_app_info.category.name[mmemo->attrib & 0x0F]);
+         printf("\"RAW %d %s\"\n", mmemo->attrib & 0x0F, memo_app_info.category.name[mmemo->attrib & 0x0F]);
          utf = charset_p2newj(memo_app_info.category.name[mmemo->attrib & 0x0F], 16, char_set);
          str_to_csv_str(csv_text, utf);
          fprintf(out, "\"Memos > %s\"\n", csv_text);

otherconv.c

@@ -165,7 +165,6 @@ void otherconv_free(void)
  */
 char *other_to_UTF(const char *buf, int buf_len)
 {
-   size_t rc;
    char *outbuf;
    gsize bytes_read;
    GError *err = NULL;
@@ -174,7 +173,7 @@ char *other_to_UTF(const char *buf, int buf_len)
 #ifdef OTHERCONV_DEBUG
    jp_logf(JP_LOG_DEBUG, "%s:%s reset iconv state...\n", __FILE__, __FUNCTION__);
 #endif
-   rc = g_iconv(glob_frompda, NULL, NULL, NULL, NULL);
+   g_iconv(glob_frompda, NULL, NULL, NULL, NULL);
 #ifdef OTHERCONV_DEBUG
    jp_logf(JP_LOG_DEBUG, "%s:%s converting   [%s]\n", __FILE__, __FUNCTION__, buf);
 #endif

plugins.c

@@ -239,7 +239,7 @@ static int get_plugin_info(struct plugin_s *p, char *path)
    const char *err;
    char name[52];
    char db_name[52];
-   int version, major_version, minor_version;
+   int major_version, minor_version;
    void (*plugin_versionM)(int *major_version, int *minor_version);
 
    p->full_path = NULL;
@@ -292,7 +292,6 @@ static int get_plugin_info(struct plugin_s *p, char *path)
       return EXIT_FAILURE;
    }
    plugin_versionM(&major_version, &minor_version);
-   version=major_version*1000+minor_version;
    if ((major_version <= 0) && (minor_version < 99)) {
       jp_logf(JP_LOG_WARN, _("Plugin:[%s]\n"), path);
       jp_logf(JP_LOG_WARN, _("This plugin is version (%d.%d).\n"),

search_gui.c

@@ -391,7 +391,6 @@ static int search_plugins(const char *needle, const GtkWidget *clist)
    GList *plugin_list, *temp_list;
    gchar *empty_line[] = { "","" };
    char str2[SEARCH_MAX_COLUMN_LEN+2];
-   int found;
    int count;
    int case_sense;
    struct search_result *sr, *temp_sr;
@@ -401,7 +400,6 @@ static int search_plugins(const char *needle, const GtkWidget *clist)
    plugin_list = NULL;
    plugin_list = get_plugin_list();
 
-   found = 0;
    case_sense = GTK_TOGGLE_BUTTON(case_sense_checkbox)->active;
 
    count = 0;

sync.c

@@ -1162,7 +1162,6 @@ static int sync_fetch(int sd, unsigned int flags,
    struct DBInfo info;
    char db_copy_name[MAX_DBNAME];
    GList *file_list;
-   GList *end_of_list;
    int palmos_error;
    int dbIndex;
    pi_buffer_t *buffer;
@@ -1216,8 +1215,6 @@ static int sync_fetch(int sd, unsigned int flags,
 
    rename_dbnames(palm_dbname);
 
-   end_of_list=NULL;
-
    full_backup = flags & SYNC_FULL_BACKUP;
 
    /* Fast sync still needs to fetch Saved Preferences before exiting */
@@ -1235,7 +1232,6 @@ static int sync_fetch(int sd, unsigned int flags,
 
    start=cardno=0;
    file_list=NULL;
-   end_of_list=NULL;
 
    buffer = pi_buffer_new(32 * sizeof(struct DBInfo));
 

todo_gui.c

@@ -1791,7 +1791,7 @@ void todo_clist_clear(GtkCList *clist)
 void todo_update_clist(GtkWidget *clist, GtkWidget *tooltip_widget,
                        ToDoList **todo_list, int category, int main)
 {
-   int num_entries, entries_shown, i;
+   int num_entries, entries_shown;
    gchar *empty_line[] = { "","","","","" };
    GdkPixmap *pixmap_note;
    GdkPixmap *pixmap_check;
@@ -1852,7 +1852,7 @@ void todo_update_clist(GtkWidget *clist, GtkWidget *tooltip_widget,
    comp_now=now->tm_year*380+now->tm_mon*31+now->tm_mday-1;
 
    entries_shown=0;
-   for (temp_todo = *todo_list, i=0; temp_todo; temp_todo=temp_todo->next) {
+   for (temp_todo = *todo_list; temp_todo; temp_todo=temp_todo->next) {
       if ( ((temp_todo->mtodo.attrib & 0x0F) != category) &&
              category != CATEGORY_ALL) {
          continue;
@@ -2177,8 +2177,6 @@ int todo_gui(GtkWidget *vbox, GtkWidget *hbox)
    GtkWidget *vbox_temp;
    GtkWidget *separator;
    GtkWidget *label;
-   time_t ltime;
-   struct tm *now;
    char str[MAX_RADIO_BUTTON_LEN];
    int i;
    GSList *group;
@@ -2249,8 +2247,8 @@ int todo_gui(GtkWidget *vbox, GtkWidget *hbox)
    separator = gtk_hseparator_new();
    gtk_box_pack_start(GTK_BOX(vbox1), separator, FALSE, FALSE, 5);
 
-   time(&ltime);
-   now = localtime(&ltime);
+   //time(&ltime);
+   //now = localtime(&ltime);
 
    /* Make the 'Today is:' label */
    glob_date_label = gtk_label_new(" ");