New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI on pull requests #60

Open

EtienneBruines opened this issue May 28, 2021 · 0 comments

Contributor

EtienneBruines commented May 28, 2021

You might want to configure CircleCI tests to run on pull requests, and mark them as requirements for merging.

Mostly this one: https://circleci.com/docs/2.0/enable-checks/

Background info:

https://docs.github.com/en/github/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks

https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-status-checks-before-merging

That way, you know whether tests run before merging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment