-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-QA code in Python example #273
Comments
Hey bud! Thanks for the issue. I would definitely appreciate your assistance in rewriting the example to fix the issue! As for splitting code from markdown, we have a similar option that fetches it from an online raw github link on build of our docs. You can use it like this |
Good, now we would need repository for an examples. I'll have a look on Python and Node example today evening. So the code is coherent across various languages. |
Much appreciated bud! If you just create some gists then I will make sure to figure out where to place the code snippets in our repositories afterwards. |
Very similar example is here: I see it's significant work to do to have this API running smoothly. |
it's not about the API -> it's just that those examples take code from the |
In .md file:
https://github.com/golemfactory/golem-docs/blob/reputation-system-rework/src/pages/docs/reputation/finding-the-best-providers.md
there is the Python example, but it does not run. Module "utils" refers to a non-existing "build_parser", "print_env_info", "run_golem_example" names.
These imports are commented with "NO-QA", exactly the line below:
Probably it has been working in the past, but over a time as module utils has changed this No Quality code has been removed.
I can rewrite that example, let me know if it's fine for you.
Also, would it be possible to split python code from MarkDown? So, .md would contain something like:
Cheers,
Mateusz (Barnaba)
The text was updated successfully, but these errors were encountered: