go/analysis/passes/defers: rename Analyzer.Name to "defers"

...to match package name and avoid a minor nuisance.

Change-Id: Ifb16c6ea60cf349be36ae35eee281e95423ca24d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/527736
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
gopls-CI: kokoro <[email protected]>

Author: adonovan

go/analysis/passes/defers/defer.go renamed to go/analysis/passes/defers/defers.go

@@ -19,11 +19,12 @@ import (
 //go:embed doc.go
 var doc string
 
-// Analyzer is the defer analyzer.
+// Analyzer is the defers analyzer.
 var Analyzer = &analysis.Analyzer{
-	Name:     "defer",
+	Name:     "defers",
 	Requires: []*analysis.Analyzer{inspect.Analyzer},
-	Doc:      analysisutil.MustExtractDoc(doc, "defer"),
+	URL:      "https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/defers",
+	Doc:      analysisutil.MustExtractDoc(doc, "defers"),
 	Run:      run,
 }
 

go/analysis/passes/defers/defer_test.go renamed to go/analysis/passes/defers/defers_test.go

@@ -5,11 +5,11 @@
 // Package defers defines an Analyzer that checks for common mistakes in defer
 // statements.
 //
-// # Analyzer defer
+// # Analyzer defers
 //
-// defer: report common mistakes in defer statements
+// defers: report common mistakes in defer statements
 //
-// The defer analyzer reports a diagnostic when a defer statement would
+// The defers analyzer reports a diagnostic when a defer statement would
 // result in a non-deferred call to time.Since, as experience has shown
 // that this is nearly always a mistake.
 //

go/analysis/passes/defers/doc.go

@@ -108,11 +108,11 @@ errors is discouraged.
 
 **Enabled by default.**
 
-## **defer**
+## **defers**
 
 report common mistakes in defer statements
 
-The defer analyzer reports a diagnostic when a defer statement would
+The defers analyzer reports a diagnostic when a defer statement would
 result in a non-deferred call to time.Since, as experience has shown
 that this is nearly always a mistake.
 

gopls/doc/analyzers.md

@@ -23,6 +23,6 @@ func TestGenerated(t *testing.T) {
 		t.Fatal(err)
 	}
 	if !ok {
-		t.Error("documentation needs updating. Run: cd gopls && go generate ./doc")
+		t.Error("documentation needs updating. Run: cd gopls && go generate")
 	}
 }