change name of the notfound handler

Author: rShetty

server/error.go

@@ -18,7 +18,7 @@ type errorDetails struct {
 	MessageSeverity string `json:"message_severity"`
 }
 
-func notFoundHandler(w http.ResponseWriter, r *http.Request) {
+func notFoundError(w http.ResponseWriter, r *http.Request) {
 	instrumentation.IncrementNotFound()
 	w.Header().Set("Content-Type", "application/json")
 

server/error_test.go

@@ -12,7 +12,7 @@ func Test404Handler(t *testing.T) {
 	w := httptest.NewRecorder()
 	r := httptest.NewRequest("GET", "/hello", nil)
 
-	notFoundHandler(w, r)
+	notFoundError(w, r)
 
 	assert.Equal(t, http.StatusNotFound, w.Code)
 	assert.Equal(t, "{\"errors\":[{\"code\":\"weaver:route:not_found\",\"message\":\"Something went wrong\",\"message_title\":\"Failure\",\"message_severity\":\"failure\"}]}", w.Body.String())

server/handler.go

@@ -30,7 +30,7 @@ func (proxy *proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	if err != nil || acl == nil {
 		logger.Errorrf(r, "failed to find route: %+v for request: %s", err, r.URL.String())
 
-		notFoundHandler(rw, r)
+		notFoundError(rw, r)
 		return
 	}