Merge pull request #221 from gofiber/codex/2025-10-17-11-09-45

Author: ReneWerner87

cmd/internal/migrations/v3/parser_methods.go

@@ -14,7 +14,7 @@ import (
 func MigrateParserMethods(cmd *cobra.Command, cwd string, _, _ *semver.Version) error {
 	changed, err := internal.ChangeFileContent(cwd, func(content string) string {
 		orig := content
-		re := regexp.MustCompile(`\.(BodyParser|CookieParser|ParamsParser|QueryParser)\(`)
+		re := regexp.MustCompile(`\.(AllParams|BodyParser|CookieParser|ParamsParser|QueryParser)\(`)
 		matches := re.FindAllStringSubmatchIndex(content, -1)
 		if len(matches) == 0 {
 			return content
@@ -49,6 +49,8 @@ func MigrateParserMethods(cmd *cobra.Command, cwd string, _, _ *semver.Version)
 			if isFiberCtx(orig, ident) {
 				var repl string
 				switch method {
+				case "AllParams":
+					repl = ".Bind().URI("
 				case "BodyParser":
 					repl = ".Bind().Body("
 				case "CookieParser":

cmd/internal/migrations/v3/parser_methods_test.go

@@ -40,6 +40,7 @@ func handler(c fiber.Ctx) error {
 	assert.Contains(t, content, ".Bind().Cookie(&v)")
 	assert.Contains(t, content, ".Bind().URI(&v)")
 	assert.Contains(t, content, ".Bind().Query(&v)")
+	assert.Contains(t, content, ".Bind().URI(&p)")
 	assert.Contains(t, buf.String(), "Migrating parser methods")
 }
 

cmd/internal/migrations/v3/sendfile_config.go

@@ -0,0 +1,43 @@
+package v3
+
+import (
+	"fmt"
+	"strings"
+
+	semver "github.com/Masterminds/semver/v3"
+	"github.com/spf13/cobra"
+
+	"github.com/gofiber/cli/cmd/internal"
+)
+
+func MigrateSendFileConfig(cmd *cobra.Command, cwd string, _, _ *semver.Version) error {
+	changed, err := internal.ChangeFileContent(cwd, func(content string) string {
+		return replaceCall(content, ".SendFile", func(call string, args []string) string {
+			if len(args) != 2 {
+				return call
+			}
+
+			arg := strings.TrimSpace(args[1])
+			if arg == "" {
+				return call
+			}
+			if strings.HasPrefix(arg, "fiber.SendFile") || strings.HasPrefix(arg, "&fiber.SendFile") {
+				return call
+			}
+			if strings.HasPrefix(arg, "SendFile{") || strings.HasPrefix(arg, "&SendFile{") {
+				return call
+			}
+
+			return fmt.Sprintf(".SendFile(%s, fiber.SendFile{Compress: %s})", args[0], args[1])
+		})
+	})
+	if err != nil {
+		return fmt.Errorf("failed to migrate SendFile calls: %w", err)
+	}
+	if !changed {
+		return nil
+	}
+
+	cmd.Println("Migrating SendFile compress flag")
+	return nil
+}

cmd/internal/migrations/v3/sendfile_config_test.go

@@ -0,0 +1,71 @@
+package v3_test
+
+import (
+	"bytes"
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/gofiber/cli/cmd/internal/migrations/v3"
+)
+
+func Test_MigrateSendFileConfig(t *testing.T) {
+	t.Parallel()
+
+	dir, err := os.MkdirTemp("", "msendfile")
+	require.NoError(t, err)
+	defer func() { require.NoError(t, os.RemoveAll(dir)) }()
+
+	file := writeTempFile(t, dir, `package main
+import "github.com/gofiber/fiber/v2"
+
+func handler(c fiber.Ctx) error {
+    if err := c.SendFile("./public/index.html", true); err != nil {
+        return err
+    }
+    return c.SendFile("./public/file.txt", compressEnabled)
+}
+`)
+
+	var buf bytes.Buffer
+	cmd := newCmd(&buf)
+	require.NoError(t, v3.MigrateSendFileConfig(cmd, dir, nil, nil))
+
+	content := readFile(t, file)
+	assert.Contains(t, content, `c.SendFile("./public/index.html", fiber.SendFile{Compress: true})`)
+	assert.Contains(t, content, `c.SendFile("./public/file.txt", fiber.SendFile{Compress: compressEnabled})`)
+	assert.Contains(t, buf.String(), "Migrating SendFile compress flag")
+}
+
+func Test_MigrateSendFileConfig_Idempotent(t *testing.T) {
+	t.Parallel()
+
+	dir, err := os.MkdirTemp("", "msendfile-idempotent")
+	require.NoError(t, err)
+	defer func() { require.NoError(t, os.RemoveAll(dir)) }()
+
+	file := writeTempFile(t, dir, `package main
+import "github.com/gofiber/fiber/v2"
+
+func handler(c fiber.Ctx) error {
+    return c.SendFile("./public/index.html", true)
+}
+`)
+
+	var buf bytes.Buffer
+	cmd := newCmd(&buf)
+	require.NoError(t, v3.MigrateSendFileConfig(cmd, dir, nil, nil))
+
+	migrated := readFile(t, file)
+	assert.Contains(t, migrated, `c.SendFile("./public/index.html", fiber.SendFile{Compress: true})`)
+	assert.Contains(t, buf.String(), "Migrating SendFile compress flag")
+
+	var second bytes.Buffer
+	secondCmd := newCmd(&second)
+	require.NoError(t, v3.MigrateSendFileConfig(secondCmd, dir, nil, nil))
+
+	assert.Equal(t, migrated, readFile(t, file))
+	assert.Empty(t, second.String())
+}