You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the problem or limitation you are having in your project
I'm currently seeking to improve godot build/rebuild time. Inspired by godotengine/godot#100023, I checked files include modules/modules_enabled.gen.h and find a large portion of them are checking whether the Regex module is enabled.
Including modules/modules_enabled.gen.h in files outside of modules/ folder is not a natural dependency order and will trigger unnecessary recompile, we should avoid this as much as possible.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
A simple solution would be include regex in core since it has been used widely in the engine. The downside is the size of minimal template goes up by ~300K, should ask people exporting to web if this is acceptable.
An alternative solution is to force enabling Regex module for editor and dev build. They should not be so size sensitive. Also regex presents in many editor features, without it the editor is likely half-broken.
Describe the project you are working on
Godot
Describe the problem or limitation you are having in your project
I'm currently seeking to improve godot build/rebuild time. Inspired by godotengine/godot#100023, I checked files include
modules/modules_enabled.gen.h
and find a large portion of them are checking whether the Regex module is enabled.Including
modules/modules_enabled.gen.h
in files outside ofmodules/
folder is not a natural dependency order and will trigger unnecessary recompile, we should avoid this as much as possible.Describe the feature / enhancement and how it helps to overcome the problem or limitation
A simple solution would be include regex in core since it has been used widely in the engine. The downside is the size of minimal template goes up by ~300K, should ask people exporting to web if this is acceptable.
An alternative solution is to force enabling Regex module for editor and dev build. They should not be so size sensitive. Also regex presents in many editor features, without it the editor is likely half-broken.
This can remove most checks except:
core/io/logger.h(.cpp)
Use regex to strip ansi characters when logging to file, addressed by Core: Avoid including
modules/modules_enabled.gen.h
in headers godot#100023 with forward declaration.platform/linuxbsd/os_linuxbsd.cpp
Use regex to speed up a function.
scene/gui/rich_text_label.cpp
Use regex in some functionality.
Includes in cpp files will not trigger cascade recompile so they are fine to go with.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
As above.
If this enhancement will not be used often, can it be worked around with a few lines of script?
It is about godot build system.
Is there a reason why this should be core and not an add-on in the asset library?
It is about godot build system.
The text was updated successfully, but these errors were encountered: