You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I investigated this, as for my extension the build on Windows MSVC was failing, as libgodot-cpp.windows.template_release.x86_64.libwas over 4GB in size. Thankfully #1628 puts it back at around 3.5GB so MSVC is working again.
However even when correcting the aforementioned line of code to set( DEBUG_FEATURES "$<NOT:$<STREQUAL:${TARGET_ALIAS},template_release>>") the line in
Godot version
4.4-beta1
godot-cpp version
13cd2d9
System information
Windows 11, CMake 3.30.5, Visual Studio 2022
Issue description
When using CMake and compiling
godot-cpp::template_release
debugging features will still be enabled.Specifically in
godot-cpp/cmake/godotcpp.cmake
Line 283 in 13cd2d9
${TARGET_NAME}
is set totemplate_release
, however it needs to be${TARGET_ALIAS}
.This can also be seen in current build logs of the GitHub Actions such as
https://github.com/godotengine/godot-cpp/actions/runs/12892247119/job/35946077972
When checking the
Build test GDExtension library
step, a release version should be built, however the build command includes/D DEBUG_ENABLED /D DEBUG_METHODS_ENABLED
I investigated this, as for my extension the build on Windows MSVC was failing, as
libgodot-cpp.windows.template_release.x86_64.lib
was over 4GB in size. Thankfully #1628 puts it back at around 3.5GB so MSVC is working again.However even when correcting the aforementioned line of code to
set( DEBUG_FEATURES "$<NOT:$<STREQUAL:${TARGET_ALIAS},template_release>>")
the line ingodot-cpp/cmake/common_compiler_flags.cmake
Line 149 in 13cd2d9
Steps to reproduce
It is possible to use the same commands the CI is currently using:
Upon inspection of the generated build commands it will be visible how the debug info is always included.
Minimal reproduction project
/
The text was updated successfully, but these errors were encountered: