Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding signal type to onSignal function #294

Open
Sammyjroberts opened this issue Oct 25, 2023 · 1 comment
Open

Adding signal type to onSignal function #294

Sammyjroberts opened this issue Oct 25, 2023 · 1 comment

Comments

@Sammyjroberts
Copy link

Sammyjroberts commented Oct 25, 2023

await onSignal()

->

await onSignal(signal)

For observability I like to track what signal caused the graceful shutdown, could we add the signal as a parameter to onSignal?
I'd be willing to make the PR if that would be helpful

@rsaryev
Copy link

rsaryev commented Apr 28, 2024

Coincidentally, I've already submitted a merge request that adds the signal as a parameter to onSignal, addressing your concern. Feel free to check it out and share your thoughts!

#327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants