Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: convergence craned permissions #887

Closed
pmsl opened this issue Jan 18, 2024 · 0 comments · Fixed by #888
Closed

Optimization: convergence craned permissions #887

pmsl opened this issue Jan 18, 2024 · 0 comments · Fixed by #888
Labels
kind/bug Something isn't working

Comments

@pmsl
Copy link

pmsl commented Jan 18, 2024

Describe the bug

Intruders may use this permission to modify the workload's spec

https://github.com/gocrane/crane/blob/main/deploy/craned/rbac.yaml#L75

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: craned
rules:
......
- apiGroups:
  - apps
  resources:
  - daemonsets
  - deployments
  - deployments/scale
  - statefulsets
  - statefulsets/scale
  verbs:
  - get
  - list
  - watch
  - update

Reproduce steps

Expected behavior

Screenshots

Environment (please complete the following information):

  • K8S Version: [e.g. 1.19]
  • Crane Version: [e.g. 0.1.0]
  • Browser [e.g. chrome, safari]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant