Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化前端代码,使其通过eslint 验证 #742

Closed
PmcFizz opened this issue Apr 26, 2023 · 6 comments · Fixed by #776
Closed

优化前端代码,使其通过eslint 验证 #742

PmcFizz opened this issue Apr 26, 2023 · 6 comments · Fixed by #776
Labels
bootcamp kind/bug Something isn't working

Comments

@PmcFizz
Copy link
Contributor

PmcFizz commented Apr 26, 2023

Describe the bug
前端代码引入了eslint,用来校验代码,但目前没有用起来,依然存在很多警告和错误。

Reproduce steps
进入pkg/web目录,执行npm run lint
会检验出很多的 警告和错误。

Expected behavior
修复所有错误,选择性修复警告。

Screenshots
image

Environment (please complete the following information):

  • K8S Version: [e.g. 1.19]
  • Crane Version: [e.g. 0.1.0]
  • Browser [e.g. chrome, safari]
@PmcFizz PmcFizz added the kind/bug Something isn't working label Apr 26, 2023
@qmhu qmhu added the bootcamp label Apr 27, 2023
@JaneConan
Copy link
Contributor

[bootcamp] I would like to work on it~

@JaneConan
Copy link
Contributor

请教一下,只修复error就可以了么
image

warning 中 有一些特殊符号,想请教一下这些代表什么意思

@JaneConan
Copy link
Contributor

我执行了如下语句

npm run lint -- --fix

错误修复了大部分,然后还有88个,这些是需要手动调整的吧
image

@PmcFizz
Copy link
Contributor Author

PmcFizz commented May 4, 2023

我执行了如下语句

npm run lint -- --fix

错误修复了大部分,然后还有88个,这些是需要手动调整的吧 image

由于涉及文件非常多,且改动比较大。建议与官方开发人员协商,分批,修复,提交 review。

@JaneConan
Copy link
Contributor

@PmcFizz 好的,感谢您的指导

胡老师 @qmhu 这边我之前有联系,目前我想知道crane的前端团队负责人,再帮忙看看

目前手改了一些,并提交了pr,剩下这些需要和大家再讨论了

image

@qmhu
Copy link
Member

qmhu commented May 7, 2023

bootcamp的issue和代码提交希望能够完成一些功能方面的能力,前端主要是做一个展示和demo为主,基本功能可用即可

qingtiantongxie added a commit to qingtiantongxie/crane that referenced this issue May 11, 2023
@qmhu qmhu closed this as completed in #776 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootcamp kind/bug Something isn't working
Projects
None yet
3 participants