Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking "Launch Course Builder" with unsaved changes results in a confusing prompt #210

Open
4 tasks done
brianhogg opened this issue Feb 29, 2024 · 1 comment
Open
4 tasks done

Clicking "Launch Course Builder" with unsaved changes results in a confusing prompt #210

brianhogg opened this issue Feb 29, 2024 · 1 comment
Assignees
@brianhogg
Labels
Severity: Normal Type: Enhancement Improvements existing features or code

Comments

@brianhogg
Copy link
Contributor

brianhogg commented Feb 29, 2024 •
edited
Loading

Reproduction Steps

  1. Edit a Course
  2. Make an edit to the course content
  3. Click "Launch Course Builder" at the top without saving

Expected Behavior

Helpful message saying you need to save changes before launching the course builder

Actual Behavior

Default "you have unsaved changes" prompt. If they click Ok by accident (to navigate away) their changes will not be saved.

This issue has been recreated:

  • Locally
  • On a staging site
  • On a production website
  • With only LifterLMS and a default theme
@ideadude ideadude moved this to Awaiting Triage in Development Feb 29, 2024
@ideadude ideadude self-assigned this Feb 29, 2024
@brianhogg brianhogg added Type: Enhancement Improvements existing features or code Severity: Normal labels Feb 29, 2024
@brianhogg brianhogg mentioned this issue Feb 29, 2024
Closed
4 tasks
@brianhogg brianhogg added the Status: Has PR This issue has an open pull request label Feb 29, 2024
@brianhogg brianhogg moved this from Awaiting Triage to In Progress in Development Feb 29, 2024
@brianhogg brianhogg moved this from In Progress to Awaiting Review in Development Feb 29, 2024
@brianhogg
Copy link
Contributor Author

There's a gutenberg bug that is blocking this, see closed PR for details: #211

@brianhogg brianhogg removed the Status: Has PR This issue has an open pull request label Apr 19, 2024
@brianhogg brianhogg moved this from Awaiting Review to Blocked in Development Apr 19, 2024
@brianhogg brianhogg assigned brianhogg and unassigned ideadude Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianhogg brianhogg

Labels
Severity: Normal Type: Enhancement Improvements existing features or code
Projects
Development
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianhogg @ideadude